chore: Port the ISO 8601 time structs to snaps-utils#3287
Merged
GuillaumeRx merged 4 commits intomainfrom Apr 1, 2025
Merged
Conversation
GuillaumeRx
changed the title
luxon to snaps-utils and port the utils/structs.luxon to snaps-utils and port the utils/structs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 511 512 +1
Lines 11328 11331 +3
Branches 1747 1747
=======================================
+ Hits 10761 10764 +3
Misses 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuillaumeRx
changed the title
luxon to snaps-utils and port the utils/structs.snaps-utils
FrederikBolding
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves 2 refiners related to ISO 8601 time strings to
snaps-utils, this allows the refiner to be used in other places (required for #3282).